Compilation error on iOS

[inactive123]

@barbudreadmon

This has happened as of today.

This is a log from our buildbot -

http://p.0bl.net/17115

[inactive123]

I would strongly recommend not using C++11 features like 'shrink_to_fit' if you don't have to, Using C++11 in most cases is unnecessary, not to mention it makes it harder to port this code to platforms where there is no C++11 compiler available. And the platforms I am talking about will never get an updated C++ compiler so there is no point in hypothetical 'what if' scenarios, it just cuts off platforms like Xbox OG/360/PS3 forever (in what in my book, is for no real, valid reasons).

If you have to use C++, stick with C++98, at least that is relatively backwards compatible.

[barbudreadmon]

I'm surprised you got an issue only today, those functions have been there for months, perhaps years.

C++11 is used upstream for midway hardware, but this hardware doesn't work in fbalpha-libretro at the moment anyway (and i think it's still WIP upstream)

[barbudreadmon]

Just to make sure, the c++98 equivalent would be :

std::basic_string<char>(dip_option->values_str).swap(dip_option->values_str);

std::vector<macro_core_option_value, std::allocator<macro_core_option_value> >(macro_option->values).swap(macro_option->values);

std::basic_string<char>(macro_option->values_str).swap(macro_option->values_str);

?