search

barbudreadmon / fbalpha-backup-dontuse-ty

Deprecated port of Final Burn Alpha to Libretro (v0.2.97.43).
61 stars 43 forks source link

Donkey Kong (US Set 1) - high score gets corrupt, game won't work #162

Closed jerrykurtz closed 6 years ago

jerrykurtz commented 6 years ago

The high score file seems to get corrupt, and when that happens, the game won't load. Deleting the high score file gets it to work.

barbudreadmon commented 6 years ago

With the hiscore.dat from the repo ?

barbudreadmon commented 6 years ago

Happens with both the new and the old format. That's weird, the libretro port create a "dkong.hi" file, it seems this is the file causing issues (deleting it fix the corruption), but i don't see any such file created when playing on standalone. I'll investigate this.

jerrykurtz commented 6 years ago

Thank you. I was going to put together some detailed instructions to reproduce the problem this weekend, but it appears you beat me to it.

dinkc64 commented 6 years ago

barbudreadmon, I have a feeling you didn't get my pm before the forum died (again). On that topic, we have a new server all set up and should be up within a day or 2. The reason I'm writing here is regarding that the dkong.hi you sent me. Have a look inside it, notice the config stuff in there that has nothing to do with a normal dkong.hiscore stuff? I've seen this before, many times over the years. Somewhere in lr-fba you're overwritting past a memory buffer/corrupting heap, which is leading to garbage leaking into the game's ram etc. Also, notice the reference to karnovr in there? I have a feeling the problem with karnovr is related. Simply going 1 character past a buffers allocated size will do this, f.ex: char dink[3]; dink[3] = 'x'; that's because the heap is stored like this: char dink[3]; // in memory: xxx#### x = char, # = size of the allocated memory. when the compilers heap system goes backwards, sorta like a link list, to keep track of things, and you've overwritten into the "allocated size" portion of the memory, it literally goes bonkers. So, it's time to get address sanitizer out. and possibly other tools to help with that. :) best regards and bye for now,

OBurgerGuy commented 6 years ago

having this issue as well, and (set 2) and Pauline hack does the same thing

OBurgerGuy commented 6 years ago

burgertime (midway) has corrupt characters as well

barbudreadmon commented 6 years ago

The hiscores seems ok now, sadly it didn't fix the issue in karnovr.

OBurgerGuy commented 6 years ago

I’ll wait until the rest of the tagged bugs are addressed, is there an eta from dev to .43?

barbudreadmon commented 6 years ago

Nope