Possible cps2 retroachievements solution

barbudreadmon / fbalpha-backup-dontuse-ty

Deprecated port of Final Burn Alpha to Libretro (v0.2.97.43).

61 stars 43 forks source link

Possible cps2 retroachievements solution #189

Closed salvadorc17 closed 6 years ago

salvadorc17 commented 6 years ago

This should allow to capture cps2 memory also, to avoid games crash on Ralibretro

barbudreadmon commented 6 years ago

Where does the 0x004000 come from ?

barbudreadmon commented 6 years ago

ok, i think i understand, you want to add the CpsRam660 into the pointer ? I don't think this commit will achieve this, you are just offsetting the pointer, so :

you won't have the first 0x004000 bytes of CpsRamFF
you'll have the 0x004000 bytes after CpsRamFF, but they aren't the bytes from CpsRam660
you won't return the right size for CpsRamFF + CpsRam660 (which is 0x010000 + 0x004000)

I'm not sure how to achieve this, i'll look into it if that's what you want to do.

salvadorc17 commented 6 years ago

Yes youre right, that is what supposed to get for the extra cps2 memory, but without it works good.

barbudreadmon commented 6 years ago

without it works good

Are you sure ? I think i found how to handle this extra memory, except it makes the code really ugly and complex, so i would prefer only reporting CpsRamFF to RA if CpsRam660 is not really needed.

barbudreadmon commented 6 years ago

I close, let me know in #182 if there are still issues with my last commit.