search

barbudreadmon / fbalpha-backup-dontuse-ty

Deprecated port of Final Burn Alpha to Libretro (v0.2.97.43).
61 stars 43 forks source link

Refactor android jni makefiles #195

Closed webgeek1234 closed 6 years ago

barbudreadmon commented 6 years ago

Are you sure about this ? I remember having tons of issues with c(xx)flags before finding the right settings in jni makefiles

webgeek1234 commented 6 years ago

It compiles with ndk r15c for all archs, that's technically all I can say. I haven't used fba myself, this is mainly an attempt to clean up all the libretro jni makefiles to be more unified and sane. Were these issues compile time or runtime? I can try and dig up something to test with or I can upload a build for you to test if you've already got it set up and don't have a newer ndk available to build with.

barbudreadmon commented 6 years ago

cflags and cxxflags were both defined, but for whatever reason it was using the cflags to build cpp (or the reverse, i don't remember exactly), which generated tons of warnings at compile time on the buildbot, and perhaps issues at runtime (didn't test it myself). I think https://github.com/libretro/fbalpha/commit/acfe2b6d98b0651faf6d6ca22aef89cf99d29cf9 was the commit which solved this issue.

webgeek1234 commented 6 years ago

I'm not getting any more warnings than other cores. Maybe 10 or so. If that's the only concern, I think this is good to go. If a runtime problem gets reported, I'll scramble a test and get it worked out.