barbudreadmon / fbalpha-backup-dontuse-ty

Deprecated port of Final Burn Alpha to Libretro (v0.2.97.43).
61 stars 43 forks source link

Dip switches as core options #45

Closed andres-asm closed 8 years ago

andres-asm commented 8 years ago

@AkimanBengus do you think you can add dip switches to core options and name them correctly depending on the game?

AkimanBengus commented 8 years ago

Hello @fr500 , are you reading in my mind? :-) I'm working on it for 2 weeks and I have quite finish. I will normally commit today or tomorrow.

andres-asm commented 8 years ago

Hah amazing

On Mon, Nov 2, 2015, 2:13 AM David notifications@github.com wrote:

Hello @fr500 https://github.com/fr500 , are you reading in my mind? :-) I'm working on it for 2 weeks and I have quite finish. I will normally commit today or tomorrow.

— Reply to this email directly or view it on GitHub https://github.com/libretro/libretro-fba/issues/45#issuecomment-152939439 .

AkimanBengus commented 8 years ago

Hello @fr500, I just committed the DIP Switch implementation. If you have time, is it possible for you to test it with some of your favorite games? I already did some test with CPS1, CPS3, Neogeo and some other old games. Thanks in advance

andres-asm commented 8 years ago

works great as far as I'm concerned! were you familiar with the fba codebase already?

barbudreadmon commented 8 years ago

@AkimanBengus I just ported fba 0.2.97.37 to libretro-fba. Everything seems to be ok but feel free to check if i didn't mess with your commits over the past months.

andres-asm commented 8 years ago

seems the UNIBIOS mode doesn't work but DIPSWITCH UNIBIOS works

barbudreadmon commented 8 years ago

i noticed they added a new bios rom ( v2.bin => MVS USA ver. 5 (4 slot) ), not 100% sure i understood how @AkimanBengus 's new code is handling all those bioses but i tried to modify it anyway, did my last commit fix neogeo modes ?

AkimanBengus commented 8 years ago

I didn't try yet but it seems good to me.

AkimanBengus commented 8 years ago

@fr500 who said:

were you familiar with the fba codebase already?

No I wasn't, I'm just trying to understand what's happening in the code and I compare a lot with the win32 stand alone version to reflect features as much as possible. With the DIP Switch addition, some games work now like Red Earth (CPS3) but maybe others too. This is because DIP switches initialize some flags that weren't before like cps3_dip, NeoSystem and region in megadrive. So many small issues are maybe fixed thanks this :-)

I have 2 or 3 things in mind to implement that are quite finished:

barbudreadmon commented 8 years ago

Nice work again, thanks for the help :)

bbhenry commented 8 years ago

can someone explain how exactly can I get to the dip switch menu? I am on fba v 0.2.97.37. I can't seem to find it in CPS 1 2 or 3 games. The NeoGeo one works by the way.