barbushin / javascript-errors-notifier

Google Chrome and Firefox extension that notifies about JavaScritp errors by icon in address bar & popups
MIT License
205 stars 62 forks source link

Microsoft Edge support #92

Open fairking opened 4 years ago

fairking commented 4 years ago

The extension doesn't work in Microsoft Edge,

It throws the following error:

Uncaught TypeError: Cannot read property 'url' of null
    at handleNewError (content.js:62)
    at HTMLDocument.<anonymous> (content.js:95)
handleNewError @ content.js:62
(anonymous) @ content.js:95
error (async)
codeToInject @ VM8647:58
(anonymous) @ VM8647:70
(anonymous) @ content.js:172
(anonymous) @ content.js:1

image

fairking commented 4 years ago

image

image

neochief commented 4 years ago

I think I managed to make a fix for this problem. Can you please test this fork and let me know whether it works for you? https://github.com/neochief/javascript-errors-notifier (download the archive, unarchive, then load unpacked extension from withing Chrome's Extensions page)

fairking commented 4 years ago

Tested. it is working. With no errors it is not shown as red and there is no error Cannot read property 'url' of null. Within an error it shows the error and highlighted with red color. Thanks @neochief