Remove unncessary final, fixes PHP 8 compatibility

barbushin / php-console

Handle PHP errors, dump variables, execute PHP code remotely in Google Chrome

https://chrome.google.com/webstore/detail/php-console/nfhmhhlpfleoednkpnnnkolmclajemef

MIT License

1.34k stars 283 forks source link

Remove unncessary final, fixes PHP 8 compatibility #173

Open Seldaek opened 3 years ago

Seldaek commented 3 years ago

Using this library on PHP 8 leads to this warning:

PHP Warning: Private methods cannot be final as they are never overridden by other classes in vendor/php-console/php-console/src/PhpConsole/Connector.php on line 101

This PR fixes that in a less intrusive way than #171

closes #171

Seldaek commented 3 years ago

@barbushin if you have a few minutes to merge and tag a release for this it'd be great.