Adding support to keep original Filename of Attachment and open more flexibility

[fglueck]

can be extend with settings like "OVERWRITE_EXISTING _FILES" or like "GENERATE_FILENAME_IF_FILE_EXISTS"...

[Sebbo94BY]

@fglueck can you please resolve the conflicts?

[Sebbo94BY]

@fglueck friendly reminder :)

[Sebbo94BY]

Can you please also squash your commits at the end, so that it's only one?

It would be also cool, when the commit message would be Adding support for "original" Filename instead of Update Mailbox.php.

Thank you! :)

[fglueck]

sorry I miss the button "Squash and merge".

Is it possible that you must first "allow" this? https://github.blog/2016-04-01-squash-your-commits/

[Sebbo94BY]

I have unfortunately no permissions to change any settings of this project.

But you can usually rebase and squash locally and force push the changes, don't you?

Ok, if it's not possible, I also can squash and merge it through the buttons here. :)

[Sebbo94BY]

Wouldn't it be a bit more beautiful and more human readable, when there would be some more underscores in the constant names? Like this?

    public const ATTACH_FILE_NAME_RANDOM = 1; // Filename is unique (random)
    public const ATTACH_FILE_NAME_ORIGINAL = 2; // Filename is Attachment-Filename
    public const ATTACH_FILE_NAME_ITTERATED = 3; // Filename is Attachment-Filename but if allready exists it will be extend by Number (#nr)

[fglueck]

Your right, I change the names and add itterated filename.

[Sebbo94BY]

Perfect, I've already seen it.

There are some more reviews (see above). :)

[fglueck]

You meen the "squash" ? I never do this before... so I can try to do this...

[Sebbo94BY]

No, I mean these pending reviews in the code.