Project Feedback

[barcabarca216]

@egillespie Can you take a look at this? It's hosted here and meets the following criteria:

• [x] At every URL, you respond with HTML, starting with an h1 element (though for this project, it doesn't have to be a complete HTML page)
• [x] When a user visits /, they see a greeting
• [x] When a user visits /random-joke, they see one of at least three knock-knock jokes (Math.random() may be useful 😉)
• [x] When a user visits /cuteness, they see a picture of a cute animal (I'm sure you can find one on the Internet 😛)
• [x] At every other URL, display an error page (if you want to make it funny, see these examples for inspiration)
• [x] The error page includes the requested URL, similar to Google's error page
• [x] Every page that is not the homepage (/) contains a link to it

[egillespie]

LOL That's a great error page! Overall, the project is really good too. I do have one suggestion to make your code easier to read, and there's one criteria you missed:

Splitting up strings

To make your code easier to read (i.e. to avoid having to scroll horizontally a lot), try breaking up your strings like this:

response.end(
  '<h1>HOME</h1>'
  + '<p>HOW ARE YOU THIS FINE DAY?</p>'
  + '<a href="/cuteness">Click here for adorable animals</a>'
  + ' <a href="/random-joke">Click here for hilarious jokes</a>'
)

Error page does not show bad URL

Your error page literally made me laugh out loud, but it doesn't show the requested URL per the second-to-last criteria. Do you mind adding that in?

---

After you’ve made your changes and pushed them to GitHub and your hosted site, give it a once-over to make sure it looks right, then comment back here and I’ll take another look.

Thanks! :rocket:

[barcabarca216]

Not sure if the requested URL part is correct but it is updated.

[egillespie]

Hi @barcabarca216, one thing I would recommend is to double-back to the Use JavaScript to collect, remember, and display info lesson and follow the steps on the first page to install the JavaScript linter. The indenting of your if/else if/else blocks is misaligned and makes it difficult to catch issues in your code.

As for showing the URL on the error page, here are some suggestions:

There are no comparisons in else

I see the following line:

else (request.url = '/lostloveandregrets')

I think you should remove everything after else on that line. if/else tests should look like this:

if (a == b) {
  // ...
} else {
  // ...
}

Add request.url to the error response

If I visit the page /bad-url, I would actually like to see something like this on the error page:

This is not the page you are looking for: /bad-url

Notice how the value of request.url is added to the end of the message.

---

Give these a shot. If you have questions, hit me up in class and I'll work through them with you.

Good luck! ☘️

[barcabarca216]

I had the js-linter installed but breaking up the strings caused a lot of errors and realignments. I added the url value to the error page. Let me know if I am making any progress.

[egillespie]

Yeah, now you're cooking with fire! 🔥 :shipit: