search

barchandune / doubango

Automatically exported from code.google.com/p/doubango
0 stars 0 forks source link

Route header field of BYE that are send from callee is in reverse order #108

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1.Send BYE from callee

What is the expected output? What do you see instead?

What version of the product are you using? On what operating system?
doubango r675

Please provide any additional information below.
this is a patch

diff -r f7c0ad6c9a3d -r 7f5f94671e55 doubango/tinySIP/src/dialogs/tsip_dialog.c
--- a/doubango/tinySIP/src/dialogs/tsip_dialog.c        Thu May 10 22:33:49 
2012 +0900
+++ b/doubango/tinySIP/src/dialogs/tsip_dialog.c        Thu May 10 21:28:40 
2012 +0900
@@ -752,7 +752,7 @@
                                self->record_routes = tsk_list_create();
                        }
                        if((route = tsk_object_ref((void*)recordRoute))){
-                               tsk_list_push_back_data(self->record_routes, 
(void**)&route); /* Copy non-reversed. */
+                               tsk_list_push_front_data(self->record_routes, 
(void**)&route); /* Copy non-reversed. */
                        }
                }
        }
~

Original issue reported on code.google.com by nakai.to...@gmail.com on 11 May 2012 at 9:07

GoogleCodeExporter commented 9 years ago 
The patch doesn't look correct. Should be:
+                               tsk_list_push_back_data(self->record_routes, 
(void**)&route); /* Copy non-reversed. */
-                               tsk_list_push_front_data(self->record_routes, 
(void**)&route); /* Copy non-reversed. */

Fixed in r703

Original comment by boss...@yahoo.fr on 17 May 2012 at 9:43