search

barchandune / imsdroid

Automatically exported from code.google.com/p/imsdroid
0 stars 0 forks source link

[ Full screen / size / ratio of picture on differents terminals ] suggested patch #194

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Hi , 

In First , "Chapeau bas !" for your application ;-)

Here i make a suggestion of patch to maintain a good ratio when viewing the 
video, and maximize the display on the different terminals. ( Toshiba AC100 , 
Samsung Galaxie S , HTC 

Have attach patch file and screenshot 

Bye ,

What steps will reproduce the problem?
1.Select full screen mode  
2.Make a video call  
3.

What is the expected output? What do you see instead?
The video d'ont have a good ratio.

What version of the product are you using? On what operating system?
r366

Please provide any additional information below.

patch: 

Index: default.properties
===================================================================
--- default.properties  (révision 370)
+++ default.properties  (copie de travail)
@@ -10,4 +10,4 @@
 # Indicates whether an apk should be generated for each density.
 split.density=false
 # Project target.
-target=android-5
+target=android-8
Index: AndroidManifest.xml
===================================================================
--- AndroidManifest.xml (révision 370)
+++ AndroidManifest.xml (copie de travail)
@@ -109,6 +109,8 @@

    <uses-feature android:name="android.hardware.camera" />
+   <uses-feature android:name="android.hardware.camera.autofocus" />

+<supports-screens android:smallScreens="true" android:normalScreens="true" 
android:largeScreens="true" android:anyDensity="true"/>

 </manifest> 
\ No newline at end of file
Index: src/org/doubango/imsdroid/media/MyProxyVideoConsumer.java
===================================================================
--- src/org/doubango/imsdroid/media/MyProxyVideoConsumer.java   (révision 370)
+++ src/org/doubango/imsdroid/media/MyProxyVideoConsumer.java   (copie de travail)
@@ -128,8 +128,8 @@
        final Canvas canvas = this.preview.holder.lockCanvas();
        if (canvas != null){
            if(this.isFullScreenRequired){
-               //canvas.drawBitmap(this.rgb565Bitmap, null, this.preview.surfDisplay, 
null);
-               canvas.drawBitmap(this.rgb565Bitmap, null, this.preview.surfFrame, null);
+               canvas.drawBitmap(this.rgb565Bitmap, null, this.preview.surfDisplay, null);
+               //canvas.drawBitmap(this.rgb565Bitmap, null, this.preview.surfFrame, null);
            }
            else{
                canvas.drawBitmap(this.rgb565Bitmap, 0, 0, null);

Original issue reported on code.google.com by verney.p...@gmail.com on 8 Mar 2011 at 7:02

Attachments:

GoogleCodeExporter commented 9 years ago 
Merci pour le compliment.
As you can see, the code to resize the video while keeping the ratio is already 
part of the latest release but commented.
I think your patch could be helpful for many people.

Original comment by boss...@yahoo.fr on 8 Mar 2011 at 8:41