search

bard / emacs-run-command

Efficient and ergonomic external command invocation for Emacs
https://bard.github.io/emacs-run-command
GNU General Public License v3.0
102 stars 8 forks source link

feat: support completing-read #5

Closed bard closed 3 years ago

bard commented 3 years ago

To try: M-x customize-variable RET run-command-completion-method RET and choose "completing-read".

Fixes: #3

clemera commented 3 years ago

Thank you! Seems to work fine :+1:

clemera commented 3 years ago

Personally I would default to completing-read, this way ivy and helm will be automatically used when their mode is enabled. Though if you use specific features of them you could check for the mode (at runtime) instead of using featurep. For example I have helm and ivy installed but usually prefer to use default completion with Selectrum.

bard commented 3 years ago

Personally I would default to completing-read, this way ivy and helm will be automatically used when their mode is enabled. Though if you use specific feature of them I would check for the mode instead of using featurep. For example I have helm and ivy installed but usually prefer to use default completion with Selectrum.

I just did the former, but the latter seems like an even better idea, I'll do that instead.

bard commented 3 years ago

@clemera merged. Thanks for reporting and for taking the time to test.