replaced octal with hex literal to prevent crash in newer firefox

bard / mozrepl

Remotely control Firefox and other Mozilla apps with JavaScript

510 stars 64 forks source link

replaced octal with hex literal to prevent crash in newer firefox #60

Closed erjoalgo closed 9 years ago

rpl commented 9 years ago

@erjoalgo Thanks a lot for catching it, I'm merging this in #61, where I'm preferring the new octal literal syntax (0o600) which makes permission more recognizable.

but I'm unable to reproduce the crash, I managed to break mozrepl only by adding "use strict"; to the repl.js file.

May I ask you on which Firefox version does it crash?

rpl commented 9 years ago

Merged as #61

erjoalgo commented 9 years ago

Thanks, I noticed the errors on Firefox 39.0.3, I noticed the telnet port wasn't coming up so I perhaps I assumed it was a crash when I was just forgetting to enable "Run on startup", it may have been just a warning. I like that syntax better as well.