bardeci / gambatte-dms

Gambatte-DMS is a GB/GBC emulator for handheld devices, using a modified Gambatte core.
GNU General Public License v2.0
66 stars 21 forks source link

GameShark cheats not working. #24

Open leomontenegro6 opened 2 years ago

leomontenegro6 commented 2 years ago

I'm using this emulator on my PocketGo v1. Recently, I tried using the cheats feature to add a GameShark code into Pokemon Crystal's USA version, but I couldn't make it work. It worked in mGBA on my desktop, but not on Gambatte-DMS (build version 20200628-164119 that came in the MiyooCFW). More details are below:

  1. Got the Pokemon Crystal (U) rom from my microSD card, copied to my desktop, and ran it through the mGBA emulator;
  2. Added the GameShark cheat "9120F1D0 – list Rare Candy in any PokeMarts", and went to a store. The first item (Poke Ball) was replaced by Rare Candy, so I can buy it;
  3. Opened the game through Gambatte-DMS in my PocketGo, and tried adding the same GameShark cheat from item 2. I made sure to tick the checkbox on the left of the code as well. Didn't work, with the first item still being the Poke Ball.

Am I missing something from my tests? Or am I right to assume that GS cheats aren't working?

bardeci commented 2 years ago

I'm afraid i can't help you with your specific issue, as gameshark/gamegenie cheats were already implemented in gambatte through an internal function when i got the code.

I simply added menus to enable cheatcodes from the emulator. When i did this, i tested some gameshark and gamegenie codes to make sure they worked, and they did in my tests.

Of course, i didn't test every code from every ROM, i just tested a couple dozen codes on some ROMs to make sure my menus correctly passed the cheat codes into the appropiate functions, but i don't really know how those functions work internally.