bardisty / gruvbox-rofi

Gruvbox dark and light color themes for Rofi
https://git.io/gruvbox-rofi
MIT License
65 stars 5 forks source link

Theme broken #4

Open tamis-laan opened 2 years ago

tamis-laan commented 2 years ago

After updating Rofi the theme is broken, the text turned black and the highlighting is gone.

Running Rofi version 1.7.0

DaveDavenport commented 2 years ago

With the removal of a lot of deprecated option and glue code to make old deprecated options work some themes are broken.

On the rofi github dicussion page there are several quick fixes mentioned.

I think adding something like this ( effect of a change from 1.6.1) fixes the text colour:

element-text, element-icon {
    background-color: inherit;
    text-color:       inherit;
}
tamis-laan commented 2 years ago

With the removal of a lot of deprecated option and glue code to make old deprecated options work some themes are broken.

On the rofi github dicussion page there are several quick fixes mentioned.

I think adding something like this ( effect of a change from 1.6.1) fixes the text colour:

element-text, element-icon {
    background-color: inherit;
    text-color:       inherit;
}

I see, adding this to gruvbox-common.rasi indeed fixes the problem. Maybe update the repo?

DaveDavenport commented 2 years ago

I did: https://github.com/davatorium/rofi/blob/next/themes/gruvbox-common.rasi#L128

tamis-laan commented 2 years ago

Oh lol, I didn't know rofi included gruvbox theme :-P