Hidden columns information does not get saved/loaded

[GoogleCodeExporter]

What steps will reproduce the problem?
1. hide a column in tasks tab
2. save project
3. re-open project

What is the expected output? What do you see instead?
All columns are visible, even those marked as hidden before which should be 
hidden again.

What version of the product are you using? On what operating system?
Revision/change 647 (6d5756fbbc3c).

Additional information:
The hidden column property does not get written to the output file. I tried to 
fix this but don't know whether it's the right way to do it. (I also already 
sent an email to contribution@ganttproject.biz about this.) I'm not sure 
whether the diff/patch has the right format since my Eclipse doesn't like the 
Mercurial plugin. Sorry if this causes any inconvenience.

Original issue reported on code.google.com by marcus11...@googlemail.com on 24 Aug 2011 at 6:53

Attachments:

• ganttproject-load-hiddencolumns.diff

[GoogleCodeExporter]

What's the purpose of saving hidden columns data? To keep their widths?

Original comment by dbarashev on 6 Sep 2011 at 11:25

[GoogleCodeExporter]

Do you refer to (1) data inside the columns OR (2) data about the columns in 
general?

For (1) If not, the counterquestion is why have hidden columns at all?

For (2) If the data is relevant (that's why it's saved) but not in all 
situation (that's why they are hidden), one would assume it's still not so 
"very" relevant when the project is opened again.

In my special situation: 
1. import tasks from database through custom import (get's database IDs)
2. change some task dates in GanttProject
3. save project file 
4. open project file
5. change some (possibly other) task dates in GanttProject
6. export tasks to database through custom exporter (understands database IDs)

Original comment by marcus11...@googlemail.com on 7 Sep 2011 at 8:18

[GoogleCodeExporter]

I'm sorry if setting the type to "defect" was incorrect. The reason was that I 
regarded the issue as a loss of information (in terms of configuration).

It could also be seen as an enhancement if you like.....

Original comment by marcus11...@googlemail.com on 8 Sep 2011 at 5:27

[GoogleCodeExporter]

I think that your explanation, why you want hidden columns, makes sense.
Your patch looks good to me, if Dmitry also agrees I am happy to commit it.

PS I do not know if you are planning to make more changes to GanttProject, if 
so it might be convenient to create a clone. For each issue you handle you 
could create a branch. Then it is fairly easy for us to merge your changes into 
the default repository when they are accepted.

Original comment by maarten....@gmail.com on 8 Sep 2011 at 8:49

[GoogleCodeExporter]

Yes, Maarten, go ahead and submit it.

Original comment by dbarashev on 9 Sep 2011 at 9:32

• Changed state: Accepted
• Added labels: CustomColumns, ProjectStorage, __Target-Praha

[GoogleCodeExporter]

This issue was closed by revision a660a283083d.

Original comment by maarten....@gmail.com on 12 Sep 2011 at 3:50

• Changed state: Fixed

[GoogleCodeExporter]

Original comment by dbarashev on 27 Nov 2011 at 7:50

• Changed state: FeelFreeToTest

[GoogleCodeExporter]

Original comment by dbarashev on 22 Sep 2014 at 12:19

• Changed state: Verified