search

bardsoftware / ganttproject

Official GanttProject repository.
http://ganttproject.biz
GNU General Public License v3.0
860 stars 301 forks source link

Cannot not get Veteran's Day(11/11 & 11/12) to drop from US Holiday Calendar after establishing the calendar. #826

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I have established my US calendar and I am trying to remove 11/11/13 and 
11/12/13 from the holiday calendar as we work those days. No matter what I try, 
nothing works. I can get other holidays to drop from the calendar like 
Thanksgiving Day or Labor Day, but not 11/11 or 11/12. It is coded as 
11/11/0001 and 11/12/0001 in the drop down box, not the usual 11/11/2013 or 
11/12/2013.

Original issue reported on code.google.com by dauck...@gmail.com on 12 Aug 2013 at 5:52

GoogleCodeExporter commented 9 years ago 
Thanks for reporting. You can fix it manually by editing the file 
`plugins/net.sourceforge.ganttproject/data/resources/calendar/i18n_us.calendar` 
which sits in your GanttProject installation directory. It is XML file where 
holidays are defined like this:
<date year="2012" month="1" date="16"/>

Veteran's day is defined as a repeating holiday (with no year) which is 
probably the reason why you can't delete it in the UI. Just remove its entry. 
And oh, it is mentioned twice. Delete both lines :)

Original comment by dbarashev on 12 Aug 2013 at 10:03

GoogleCodeExporter commented 9 years ago 
Thanks for the help!

Original comment by dauck...@gmail.com on 13 Aug 2013 at 1:01

GoogleCodeExporter commented 9 years ago 
I was able to open the file in notepad and eliminate the two lines of code you 
suggested and then save the changes to the Calendar file, but it still does not 
allow me to eliminate the Veteran's Day holiday. Any suggestions?

Original comment by dauck...@gmail.com on 13 Aug 2013 at 2:58

GoogleCodeExporter commented 9 years ago 
Oh, I see, it copies calendar to the project file. So, you'll have to edit .gan 
file itself. Find tags <date year="1" month="11" day="11"/> and <date year="" 
month="11" day="11"/> (and the same for day='12") and delete them. Feel free to 
send me your project file if you want my assistance. Sorry for the troubles!

Original comment by dbarashev on 13 Aug 2013 at 3:08

GoogleCodeExporter commented 9 years ago 
I have attached it. It is file 720 NW1.gan. Also, how do you delete old files 
when you are done with them?

Original comment by dauck...@gmail.com on 13 Aug 2013 at 4:27

Attachments:

GoogleCodeExporter commented 9 years ago 
It is executable file, isn't it? Can you just send me .gan file?

Original comment by dbarashev on 13 Aug 2013 at 5:24

GoogleCodeExporter commented 9 years ago 
Is this it?

Original comment by dauck...@gmail.com on 13 Aug 2013 at 5:39

Attachments:

GoogleCodeExporter commented 9 years ago 
Hope this file is fixed now

Original comment by dbarashev on 15 Aug 2013 at 11:22

Attachments:

GoogleCodeExporter commented 9 years ago 
Thank you for your help!

Original comment by dauck...@gmail.com on 16 Aug 2013 at 2:01

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision 1d0366cc040f.

Original comment by dbarashev on 29 Oct 2013 at 12:03

GoogleCodeExporter commented 9 years ago 
So, there was a number of problems.
Fist is that US holidays calendar contained wrong entries (e.g. November 12 was 
declared as recurring holiday while actually it was a holiday in 2012 only). 
This was fixed.
Second, recurring holidays would appear in the UI twice (one time with 
year=-1). This was fixed
Third, although we could not provide a UI for removal of recurring holidays, we 
would not disable their removal. This was also fixed, and additionally 
recurring holidays are shown with appropriate label in the UI.

The remaining issue is ability to remove recurring holidays. I will create a 
separate ticket for that.

Original comment by dbarashev on 28 Nov 2013 at 11:56

GoogleCodeExporter commented 9 years ago

Original comment by dbarashev on 22 Sep 2014 at 12:23

GoogleCodeExporter commented 9 years ago 
What is the process in the latest version? (Gantt 2.6)
I would also like to disable the Nov. 11 recurring holiday

Original comment by matt.swa...@gmail.com on 3 Nov 2014 at 6:46

GoogleCodeExporter commented 9 years ago 
Did you mean 2.6.6?
Basically the same: open .gan file in any text editor and remove line

        <date year="" month="11" date="11"/>

You may as well try GanttProject 2.7 where holidays management is more easy, 
and in particular recurring holidays can be removed from UI

Original comment by dbaras...@ganttproject.biz on 4 Nov 2014 at 12:23