search

barecheck / code-coverage-action

GitHub Action that generates code coverage reports
https://barecheck.com
MIT License
61 stars 14 forks source link

Move to node16 from node12 #233

Closed rvalitov closed 1 year ago

rvalitov commented 1 year ago

Fixes #232

rvalitov commented 1 year ago

This PR assumes that you create a new release barecheck/code-coverage-action@v2 after merging.

vitaliimelnychuk commented 1 year ago

Hey @rvalitov! Thanks for making this contribution!

Changes look good, is there a specific reason why we need v2 version? If it's backward compatible with everything we already have I think we can keep v1 without asking everyone to upgrade.

rvalitov commented 1 year ago

I followed the way how all other GitHub Actions repositories handled this situation. They released a new version. I'm not sure if there was some specific reason, because it's backward compatible. But are you sure you can rerelease an action without changing a version? I'm not sure about GitHub Actions, but some repositories do not allow to modify existing release, the only way is to make a new version. What do you think?

vitaliimelnychuk commented 1 year ago

What we have here, instead of the version we use the branch - Basically, all code updates inside the branch will be applied. Basically, if you just followed the docs and used:

- name: Generate Code Coverage report
  id: code-coverage
  uses: barecheck/code-coverage-action@v1
  with:
    barecheck-github-app-token: ${{ secrets.BARECHECK_GITHUB_APP_TOKEN }}
    lcov-file: "./coverage/lcov.info"
    base-lcov-file: "./coverage/base-lcov.info"
    send-summary-comment: true
    show-annotations: "warning"

Just by merging it will work, I just tested and changed seem fine so I am deploying this new version, try to just rerun action on your side and see if everything is fine ;)

rvalitov commented 1 year ago

Yes, now it works fine. No warnings. I made a new PR to revert @v2 to @v1. #234