Implement /binary/X?output query parameter

barelyhuman / goblin

Golang binaries compiled on-demand for your system

http://goblin.run

MIT License

138 stars 4 forks source link

Implement /binary/X?output query parameter #7

Closed diamondburned closed 2 years ago

diamondburned commented 2 years ago

The ?output query parameter will be useful for outputting Windows binaries, since right now, they're not downloaded with the .exe extension. The server can implement this using the Content-Disposition header.

barelyhuman commented 2 years ago

Good find and that could be a useful parameter as well,

though I'll need someone on a windows system to test that out for me , before I merge it into the stable code.

barelyhuman commented 2 years ago

@diamondburned hey, could you try cloning the branch #8 is on and running a local docker to check if that satisfies your requirement?