search

barentsen / dave

Discovery And Vetting of K2 Exoplanets
MIT License
6 stars 3 forks source link

BLS returns negative depth which is not expected in trapezoid fit #5

Closed christopherburke closed 8 years ago

christopherburke commented 8 years ago

BLS can return a negative depth. This will raise a value error exception in the trapezoid fit. How do we want to handle such cases?

fergalm commented 8 years ago

Tom, I've seen negative depths out of BLS a couple of times too. Do you know what's going on?

mrtommyb commented 8 years ago

is it due to my pseudo-normalization?

fergalm commented 8 years ago

We're now using fbls instead of python_bls, so this bug is overcome by events.