OPUS build needs quotes

baresip / baresip-android

Baresip for Android

BSD 3-Clause "New" or "Revised" License

42 stars 19 forks source link

OPUS build needs quotes #23

Closed trampster closed 5 years ago

trampster commented 6 years ago

When building on windows subsystem for linux the OPUS build fails because ProgramFiles (x86) is in the path, the open bracket is what breaks the build.

The solution is to put quotes around the variable paths.

trampster commented 6 years ago

The RANLIB=$(RANLIB) AR=$(AR) PATH=$(BIN):$(PATH) \ lines should be RANLIB="$(RANLIB)" AR="$(AR)" PATH="$(BIN):$(PATH)" \

trampster commented 6 years ago

The zrtp build has the same problem

alfredh commented 6 years ago

hi @trampster thanks for the report.

are you able to send a Pull Request addressing the issues ?

Alfred

alfredh commented 5 years ago

I think this has been fixed now, in this commit:

https://github.com/alfredh/baresip-android/commit/afd49a3778e09bd0b8f8faada9b6ba86ed9ca7c8