search

barisssss / pdRemoteVscode

Do What The F*ck You Want To Public License
2 stars 1 forks source link

Check filename extension to figure out which compile message to send #4

Closed agraef closed 1 year ago

agraef commented 1 year ago

Fixes #1.

agraef commented 1 year ago

I'm not sure how idiomatic my Typescript code is, also there may be better ways to check the file type of the currently edited file. So feel free to edit this as you see fit.

agraef commented 1 year ago

Updated README and bumped version to 1.0.2, for your convenience. After you merged this, can you also please tag the new release and update the package, also in the marketplace? Thanks.

agraef commented 1 year ago

An update of the ChangeLog on the marketplace might be in order, too.

agraef commented 1 year ago

Sneaked a little keybinding change in here, I recently had to change this in pd-remote.el for better compatibility. (The rationale being that Ctrl+g should never be bound in Emacs by user stuff since it's the global "abort" key combo. So VS Code should follow suit with its default key bindings.)

barisssss commented 1 year ago

Hi Albert, thanks for the contribution! Looks good to me, however after merging I will modify your Javascript code to comply to Typescript standards. The Makefile and build process adjustments are appreciated; that was my first time writing a Makefile, so I'm happy to learn a bit more about that here. :)

Both #1 and #2 are fixed in this PR, so I will merge this one and close PR #3. I'll create a new release afterwards.

barisssss commented 1 year ago

See commit https://github.com/barisssss/pdRemoteVscode/commit/b44685744f79d82a63b4cfba18c5d00f1fe710d3 for the mentioned TS and formatting fixes.

agraef commented 1 year ago

Hi Baris, thanks for fixing my sloppy TS coding, much appreciated. Should be forgivable, hopefully, considering those were the very first few lines of TS I wrote, ever. ;-)

I see that the marketplace was updated, too, works like a charm, thanks!

Meanwhile, upstream pd-remote.el is at 1.1.0 and on its way into MELPA, so this should soon be as convenient to install as your extension.

I've also linked to https://github.com/barisssss/pdRemoteVscode in various places, so that pd-remote users should be able to find it.

Again, thanks for the fun and fruitful collaboration, hope that we can continue that some time. ;-)