search

barjo / atmosphere-osgi

A simple OSGi service which encapsulate an atmosphere framework.
6 stars 3 forks source link

New sample that implements transport detection example #5

Closed sergehuber closed 10 years ago

sergehuber commented 10 years ago

Hello,

I have a new commit suggestion that I implemented this afternoon, based on the Atmosphere Wiki example. I think it could also be a useful integration test to make sure that all the transports work properly. I hope you'll agree.

I have also taken the liberty to expand a little on the README file to explain how to compile the project (as I didn't immediately notice the usage of profiles), as well as the URLs to use for connecting to the samples.

Best regards, Serge Huber.

barjo commented 10 years ago

Thanks Hubber, there is a minor naming problem in the parent section of your sample. I do the merge and will update it.

sergehuber commented 10 years ago

Hi Jonathan,

Sorry about the misses in the version number, I guess I copy-pasted some code a little fast :)

Thanks for committing the changes so fast. I see you've also given me access to the repository directly ? I'm not sure how much more I can contribute to this but thanks for the vote of trust :)

Just a thought, although I'm no expert at it I think you can change the introduction text because I've tested my new detection sample and it seems to detect WebSockets on Safari 6, Chrome 30, Firefox 25 and even Internet Explorer 10. I should mention I was using it with Pax Web 3.0.3 with Jetty 8.1.14.

Another thing I didn't have time to do was check the atmosphere JQuery Javascript code if it needed updating, since I only modified the dependency on the server component. Despite this it seems to work but maybe it would be a good idea to update it. I had the idea that maybe we could somehow repackage it as a component that would expose the Javascripts (including the pure Javascript one as I'm interested in using it to integrate with AngularJS) at a configurable URL. But this might be a little complex to do as I believe Atmosphere package them as WAR files ? I would prefer not to use the WAR file directly because I like the idea of having lightweight components that can be re-used just using a basic HttpService implementation.

Best regards, Serge Huber.

Jahia’s next-generation, open source CMS stems from a widely acknowledged vision of enterprise application convergence – web, search, document, social and portal – unified by the simplicity of web content management.

http://www.jahia.com

On 11 nov. 2013, at 03:17, Jonathan Bardin notifications@github.com wrote:

Thanks Hubber, there is a minor naming problem in the parent section of your sample. I do the merge and will update it.

— Reply to this email directly or view it on GitHub.

barjo commented 10 years ago

Hi Serge,

That's nothing, no worry :)

About the jquery.atmosphere javascript, yes, it should be better to upgrade it too. I agree with you and would rather not having them package in a WAR files. One thing we can do is to use the maven coffee mill plugin. Thanks to it, we could deploy atmosphere.js, atmosphere-jquery on the maven repo packaged as javascript files. Thus being able to use them as maven dependency in our samples and apps.