bark-simulator / carla-interface

Carla-Interface for BARK
9 stars 4 forks source link

Implement filling of Observed World #4

Closed klemense1 closed 4 years ago

klemense1 commented 4 years ago

observed_world = fillFromCarlaWorld()

now that we have filled the map in #3, we need to add the information of the other agents:

Demo: have a live view of observed World in BARK (all agents move in Carla and BARK)

klemense1 commented 4 years ago
klemense1 commented 4 years ago

Improvements for viewer:

--> if that's finished, we can wrap up this issue

tin1254 commented 4 years ago

Screenshot 2019-11-21 16:15:15 Screenshot 2019-11-21 16:15:31 @klemense1 Is this fine for testing? Or it is better to have only one to two roads?

klemense1 commented 4 years ago

I would narrow it down even more, and try to not have any loops. What about those two:

image

klemense1 commented 4 years ago

It seems like we cannot just rempove part of the open drive map, we would also need to modify the 3d representation

klemense1 commented 4 years ago

Apparently, there is something wrong with routing in the carla map

klemense1 commented 4 years ago

Running both simulators in parallel isn't feasible as the bark plotting takes a lot of time Improvements 1) Improve of Speed of Pygame Viewer 2) Enable to update the bark plot at a lower frequency

klemense1 commented 4 years ago

We cannot find the controlled vehicle in Carla: --> Can we implement a Camera-View or Birds-Eye View only following the conrolled ego vehicle?

tin1254 commented 4 years ago

Apparently, there is something wrong with routing in the carla map

* in the T-Intersection, the Bark model is taking a turn for a short time

1. Is the center line correct? Switch it on when plotting!

2. Check the routing using roadgraph.print_graph(...)

Screenshot from 2019-12-02 18-30-33 Screenshot from 2019-12-02 18-34-59 The road structure is already broken with the original maps, in both map Town01 and Town02, some junctions are shown broken in bark, and some connections are disconnected in graphviz.

klemense1 commented 4 years ago

Why is the connection fro road_id=239 lane_id=29 to road_id=0, lane_id=2?

Possibility 1: There might be missing connection in the Carla xodr Map?

Possibility 2: We misinterpret the standard? Can we look into the parser of Carla? How do they parse the xodr file?

tin1254 commented 4 years ago

Why is the connection fro road_id=239 lane_id=29 to road_id=0, lane_id=2?

Possibility 1: There might be missing connection in the Carla xodr Map?

Possibility 2: We misinterpret the standard? Can we look into the parser of Carla? How do they parse the xodr file?

A connection at the junction is certainly missing https://github.com/bark-simulator/carla-interface/issues/4#issuecomment-560503364 , a similar issue is also observed in another map (town01).

It may relate to the driving direction of lanes, but it is not defined according to standard.

klemense1 commented 4 years ago

What do you mean with the driving direction relation? Can you elaborate on this?

tin1254 commented 4 years ago

What do you mean with the driving direction relation? Can you elaborate on this?

In the maps provided by carla, they defined the driving direction for every drivable lane. And also the 3D assets in Unreal map are also placed complied with right-handed driving direction. By my empirical observations, as long as the ego follows the direction and with the issue https://github.com/bark-simulator/bark/issues/191 fixed, some of the routings on carla maps would be fine.

I have to do a thorough check at each junction to confirm whether my guess of the direction is true... I have already raised an issue on Carla repo

klemense1 commented 4 years ago

Carla's direction is right-handed, however the map seems to only be valid for left-handed. We will wait for a response from the Carla issue. Until then, routing / centerline and so on cannot be used.