search

barklan / kanagawa.vscode

A VS Code port of the Kanagawa.nvim theme.
MIT License
45 stars 6 forks source link

fix(colors): make whitespace chars visible #14

Open amekusa opened 1 year ago

amekusa commented 1 year ago

Due to the color of whitespace characters (spaces and tabs) is same as the background color (#1F1F28), they are not visible unless being highlighted at the current line even if editor.renderWhitespace is not none.

Screen Shot 2022-12-19 at 10 48 53

So I changed editorWhitespace.foreground to be slightly lighter than editorIndentGuide.activeBackground #363646 but darker than
editorLineNumber.foreground #54546D.

This is the result:

Screen Shot 2022-12-19 at 11 07 55
Lamarcke commented 1 year ago

I honestly believe this is intentional. Most editors don't have editor whitespace colors, and some people don't like them.

amekusa commented 1 year ago

Hm, If it's intentional, that's ok then. Maybe I will create a fork for my own. But in my opinion, if you don't like whitespaces are visible, that is editor.renderWhitespace setting for.