search

barleybobs / homeassistant-ecowater-softener

A Homeassistant custom component to integrate Ecowater water softeners
https://github.com/barleybobs/homeassistant-ecowater-softener
MIT License
31 stars 9 forks source link

Individual sensors & more... #27

Closed ThePrincelle closed 1 year ago

ThePrincelle commented 1 year ago

Hi,

First of all, thanks for your integration. It works perfectly.

I took the liberty to improve it a bit by adding individual sensors for attributes and by adding French translation on the config flow.

Here are the new entities:

entities

They all use the original entity that hasn't changed in this version. Also, the "Water Used Today" entity, includes a last_reset value to be able to be used with statistics and the energy dashboard (that should bring water consumption support soon).

Let me know if anything needs to be changed.

Have a nice day, Maxime.

barleybobs commented 1 year ago

Hey thanks for creating this, but I have rewritten the integration to use a DataUpdateCoordinator, as it suggests in the HomeAssistant development docs. If you don't mind could you create a new pull request (to the dev branch) for the French translations. I will add credits at the bottom of the README for you.

Thanks 👍

ThePrincelle commented 1 year ago

There you go: https://github.com/barleybobs/homeassistant-ecowater-softener/pull/29

barleybobs commented 1 year ago

Thanks! I will close this PR now.