barnabycolby / MMM-Carousel

Displays a single magic mirror module at a time, rotating through the list of configured modules in a carousel-like fashion.
98 stars 33 forks source link

Display multiple modules in each transition #3

Closed barnabycolby closed 7 years ago

barnabycolby commented 8 years ago

Original request for feature

The module should allow a user to display multiple modules on the page instead of simply cycling through each module one by one. This could be done by adding an additional slides configuration option, describing the sets of modules to display together and the order to display them in. If the option is not present then the current behaviour should be preserved, displaying each non-ignored module one-by-one.

The configuration should like something like:

{
    module: 'MMM-Carousel',
    config: {
        slides: [
            ['calendar', 'newsfeed'],
            ['compliments', 'clock', 'currentweather'],
            ['weatherforecast']
        ]
    }
}

The following tests should be required:

SquirrelBNCT commented 7 years ago

I have some troubles with the MMM-Carousel Modul. It shows me always only one Modul at time. Even when I ignore some Moduls. Then i tried your slides option. But it`s the same there..

` {

module: 'MMM-Carousel', config: { slides: [ ['calendar', 'newsfeed'], ['compliments', 'clock', 'currentweather'], ['weatherforecast'] ] } },`

What did i wrong?

barnabycolby commented 7 years ago

@SquirrelBNCT This GitHub issue describes functionality that has not been implemented yet.

barnabycolby commented 7 years ago

Implemented in d593a8842d2418cc40855a69d32e5edbe3142c06