Presubmission script failing on the VSV branch

[ghost]

Hi,

Recently, I've tried to submit on the variable psf, space, variable using results generated from my usual pipeline. It failed when the presubmission script was checking the IDs of the galaxies. The error raised is the following:

RuntimeError: Unexpected galaxy IDs found.  Please check that your galaxy IDS are the same as the catalogs distributed with the Great3 simulations, and that you have passed the correct branch name.

This is apparently method independent as our team (MegaLUT) and the CEA-EPFL we both had the same issue.

Cheers

[rmandelb]

One quick thought: do you definitely have the most recent version of the presubmission script and the associated branch_id.py? If you have the original one, then that could lead to this error because we had to replace the sims and all the branch IDs changed as a result.

If you definitely have the most up-to-date one then please let us know and we can look into this more...

[rmandelb]

... but I realize now that you have been submitting to the other variable PSF branches, so this is unlikely to be the problem. Am I right that you've been okay for the other 3 variable PSF branches and it's only this one that's the problem? If so, then my suggestion is wrong.

I would be happy to play around with this more, however, the easiest way for me to do that is if you were to tar up your catalogs that you're giving it as input and I play around with running presubmission.py on them to see what's going on. Otherwise I am going to have to send you lots of ideas for places to put debug statements etc. Are the catalogs small enough that you could send them via e-mail/dropbox?

[rmandelb]

Also, @msimet , can you check that the contents of branch_id.py are correct for v-s-v? Thanks!

[msimet]

I notice that no one at all has submitted to vsv, so I'm thinking it's a problem on my part. Checking now.

[ghost]

I've checked the version of the presubmission script it's the same.

On 10/04/14 15:03, msimet wrote:

I notice that no one at all has submitted to vsv, so I'm thinking it's a problem on my part. Checking now.

— Reply to this email directly or view it on GitHub https://github.com/barnabytprowe/great3-public/issues/15#issuecomment-40074895.

[ghost]

@rmandelb do you still want the catalogs ? The total is about 60 MB. I can post them on a web server or via dropbox

[msimet]

Update: The branch-ID generating script isn't done running yet, but I can confirm that branch_id.py is wrong for variable-space-variable. I'll comment again when the script has been updated.

[barnabytprowe]

Thanks for getting onto this so quickly @msimet !

[rmandelb]

@jolfulorc - In light of this update, I don’t need the catalogs to check this out. Once branch_id.py is updated you should be fine. I’m sure that Melanie will post to let you know once the updated version is available. (thanks, Melanie!)

Sorry for all the trouble!

[msimet]

Okay, the script has been updated (and as long as I was pushing a change, I added better error messages for the situation in #14). I apologize for the error.

[rmandelb]

I see a CEA-EPFL submission on variable_psf-space-variable... I'm pleased to see that the script is working now!

[barnabytprowe]

Thanks for the very quick fix Melanie!

[barnabytprowe]

Can we close this?

[rmandelb]

Considering that there is now a submission on that branch, we should close. If there are further issues along the same lines, they can reopen this issue.

[rmandelb]

Closing #15.