search

barnabytprowe / great3-public

Public repository for the Third Gravitational Lensing Accuracy Testing Challenge
BSD 3-Clause "New" or "Revised" License
9 stars 11 forks source link

check psf using the sigma guess defined above #8

Closed dmargala closed 10 years ago

dmargala commented 10 years ago

The initial adaptive moment test on the psf does not use the default sigma guess defined previously (guess_sig=3.0). Since this is not passed in the initial test call to FindAdaptiveMom, it's actually testing with the default guess_sig=5.0, and shape measurement will end up using guess_sig=3.0 if the test passes.

rmandelb commented 10 years ago

You are correct. There are no practical implications (in the sense that there is one subfield that requires a guess of 2, and all the others are just fine whether you use 3 or 5) but the new code is certainly more correct. I’ll merge this tomorrow unless someone objects.

barnabytprowe commented 10 years ago

No objection from me

rmandelb commented 10 years ago

Merging. Thank you, Daniel, for your careful attention to detail!