search

barnacs / compy

HTTP/HTTPS compression proxy
ISC License
204 stars 34 forks source link

Fix reuse of compy folder #41

Closed RReverser closed 5 years ago

RReverser commented 6 years ago

Previously, compy was moved to /go/src/... but default GOPATH was created as /root/go, so compy was downloaded from Github on each build instead of using locally existing copy.

gaul commented 5 years ago

@RReverser Sorry don't follow -- could you explain this more fully?

RReverser commented 5 years ago

Heh, it's been a while to be sure about details. But, as far as I remember, the problem is that current commands copy compy to /go in the image, but go get then checks /root/go, doesn't find compy there, and then downloads it from Github instead of using local version.

RReverser commented 5 years ago

Aside from inefficiency, one problem with that is that any local modifications never appear in the image and so tests don't represent the actual state of things.