search

barnardos / design-system

The website and components of the Design System
https://design-system.barnardos.org.uk/
MIT License
29 stars 4 forks source link

Fix label guidance #841

Closed kelliedesigner closed 5 years ago

kelliedesigner commented 5 years ago

Guidance is missing more explicit implementation how to positional labels and inputs. https://design-system.barnardos.org.uk/patterns/gathering-information/#asking-for-names

Asking for a name has been implemented differently from the design system in products.

Screen Shot 2019-05-02 at 13 36 07

Address has been implemented differently from the design system in products.

Screen Shot 2019-05-09 at 15 42 11

Current behaviour Labels for names are positioned below the inputs and styled as hint text

Expected behaviour Labels for names are positioned above the inputs and treated as labels

kelliedesigner commented 5 years ago

This has already been addressed in #845 and #847