Add alt prop to teasers

barnardos / design-system

The website and components of the Design System

https://design-system.barnardos.org.uk/

MIT License

29 stars 4 forks source link

Add alt prop to teasers #875

Open wagg-matt opened 4 years ago

wagg-matt commented 4 years ago

As a user of the design system I want to be able to add alt tags to images within teasers So that I can add alternate text to an teaser image

Description

There currently is not an alt prop in the Teaser component to add a alt tag to the image within

Links and resources

https://github.com/barnardos/design-system/blob/master/src/components/Teaser/index.js

Acceptance criteria

[ ] Add alt prop

derekjohnson commented 4 years ago

@wagg-matt Looking at the diff I'm wondering if alt="" was deliberate. It's the standard way to tell assistive technology to ingore decorative images. The teaser images do fall into that category imo.

What do you think?

wagg-matt commented 4 years ago

@wagg-matt Looking at the diff I'm wondering if alt="" was deliberate. It's the standard way to tell assistive technology to ingore decorative images. The teaser images do fall into that category imo.

What do you think?

@derekjohnson if they're always going to be seen as being decorative, then yes. You know a lot more about a11y than I do so more than happy to take your lead on this one.