search

barnardos / design-system

The website and components of the Design System
https://design-system.barnardos.org.uk/
MIT License
29 stars 4 forks source link

try and update brand colours #881

Open ritapatel7 opened 1 year ago

ritapatel7 commented 1 year ago

Closes #000

ritapatel7 commented 1 year ago

@Ma9sha could you please review the code and check colours are fine please?

@jnpwebdeveloper I thought I had to do updates before being able to make changes to design system as it failed last time but I must have forgotten to do npm install so didn't have up to date dependancies. I have done this now and seems I can make changes without doing proper upgrade. We have changed green colour, focus colour and error colour on the main website to meet Accessibility guidelines and that's why want to update this design system. If you can check the code and approve please?

Also if you notice, I have disabled stylelint on colours section. I was trying to find where I can add new colours to the whitelist and seems to be in another plugin (barnardos stylelint config, but I cannot see where to update on there and also you may be using it so haven't changed that and instead disable stylelint on this for now). Any idea where the whitelist is so I can add these new colours to it? I've tried to look here https://github.com/barnardos/stylelint-config-barnardos but cannot see where the allowed colours are defined.