search

barnesgroupICL / Driftfusion

An open source drift diffusion code based in MATLAB for simulating semiconductor devices with mixed ionic-electronic conducting materials.
GNU Affero General Public License v3.0
48 stars 76 forks source link

Revision of function lightsource.m : Compatibility issue with MacOS? #94

Open MimaxSimm opened 1 year ago

MimaxSimm commented 1 year ago

Hello,

I have just downloaded DriftFusion, and am using it on MacOS.

Found an issue in the function "lightsource.m". Here the revision (AM15_data(2:end,1), AM15_data(2:end,2)): "" %% Start code if source_type == 'AM15' % Load AM1.5 AM15data = xlsread('AM15.xls'); AM15 = 1e-3*interp1(AM15_data(2:end,1), AM15_data(2:end,2)_, lambda, 'linear', 'extrap'); % Converts to W cm-2 nm-1 end ""

It seems that xlsread returns a first row of nans for some reason, therefore removed row one in AM15_data using (2:end). Not sure its the best option though.

Kind Regards, Maxim Simmonds PhD HZB Berlin

MimaxSimm commented 1 year ago

Additionnal small comment: Error in plotting in dpflot.gxt, the xlabel shoud be "Position [nm]" and not "Position [cm]"