search

barneygale / httpio

Python library for reading HTTP resources as random-access file-like objects using the `Range` header
Other
31 stars 5 forks source link

Requirement aiohttp is missing #8

Open frafra opened 3 years ago

frafra commented 3 years ago 
>>> import httpio
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/frafra/.cache/pypoetry/virtualenvs/draft-2Uym0jAL-py3.9/lib64/python3.9/site-packages/httpio/__init__.py", line 229, in <module>
    from .asyncio import AsyncHTTPIOFileContextManagerMixin
  File "/home/frafra/.cache/pypoetry/virtualenvs/draft-2Uym0jAL-py3.9/lib64/python3.9/site-packages/httpio/asyncio.py", line 4, in <module>
    from httpio_async import AsyncHTTPIOFile, AsyncHTTPIOFileContextManagerMixin  # noqa: F401
  File "/home/frafra/.cache/pypoetry/virtualenvs/draft-2Uym0jAL-py3.9/lib64/python3.9/site-packages/httpio_async/__init__.py", line 6, in <module>
    import aiohttp
ModuleNotFoundError: No module named 'aiohttp'

https://github.com/barneygale/httpio/blob/18c1b98e3b36156477124139afa234800fc24634/setup.py#L7-L10

samdbmg commented 3 years ago

How are you installing this? Because the version sniffing code in setup.py should add aiohttp on python >= 3.6? (A quick test in a virtualenv while doing #9 shows it seems to install for me!) https://github.com/barneygale/httpio/blob/18c1b98e3b36156477124139afa234800fc24634/setup.py#L12-L14