search

barneygale / mark2

minecraft server wrapper, written in python with twisted
Other
105 stars 27 forks source link

Ping spam when running CraftBukkit 1.6.4 RC2 on master. #123

Open Dykam opened 10 years ago

Dykam commented 10 years ago

Since c783ae14ca0012d69689e3c1cf4a8adecd46cc57 mark2.service.ping.enabled=true causes ping-spam in the console.

I was only able to get rid of it after disabling the ping service, which of course isn't preferable.

gsand commented 10 years ago

That's happening due to the slight chat format change in this commit for 1.7 support: https://github.com/mcdevs/mark2/commit/c783ae14ca0012d69689e3c1cf4a8adecd46cc57

Revert it if you want mark2 to work for minecraft server softwares that were released before 1.7.

Mark2 depends on that regex string to parse server console output. Since pre 1.7 versions of minecraft_server.jar/craftbukkit.jar/spigot.jar have a console output format that's a little bit different, it doesn't initialize a few plugins that hide the ping service disconnect messages. Mark2 pretty much starts after the Done message appears.

Dykam commented 10 years ago

So no dual-version support? It would be convenient to be able to run both in one mark2 instance.

gsand commented 10 years ago

My latest pull request has dual support.

gsand commented 10 years ago

The current github version has support for both versions.