barneygale / quarry

Python library that implements the Minecraft network protocol and data types
Other
527 stars 75 forks source link

1.18.2 support #134

Closed kotinash closed 2 years ago

fizzrepo commented 2 years ago

A temporary fix is to:

Worked for me

thatITfox commented 2 years ago

what is the path if i'm using a virtual environment?

Lars-Thestorf commented 2 years ago

If you have installed quarry using pip you can execute pip show quarry to figure out the exact install path

thatITfox commented 2 years ago

ah alr, thanks man

fizzrepo commented 2 years ago

I don't know if anything really changed in the 1.18.2 release other than the protocol number so I can try to get a PR out.

dries007 commented 2 years ago

I think more changed because I had trouble with the NBT data on server join, that's why there is no version released yet.

If you make a PR I'll test it and merge if it does work (then I likely did something else wrong).

lewisakura commented 2 years ago

I did the above 'solution' and got a nastily large error message upon connecting, which I assume is the client rejecting the NBT data that its been sent. wiki.vg does actually have a SNBT version of the data for 1.18.2, although I have no clue how to convert this to regular NBT for Quarry.

https://gist.github.com/joserobjr/d877abd88767eda006ee2d1d8779b176

dries007 commented 2 years ago

This is also what I'm struggeling with. The minecraft screen doesn't let me see the entire error message and it's nog logged to console either :(

lewisakura commented 2 years ago

From what I can tell, the error is just saying the NBT is invalid for 1.18.2 -- there's new attributes in this version, annoyingly.

ArachnidAbby commented 2 years ago

I did the above 'solution' and got a nastily large error message upon connecting, which I assume is the client rejecting the NBT data that its been sent. wiki.vg does actually have a SNBT version of the data for 1.18.2, although I have no clue how to convert this to regular NBT for Quarry.

Unsure if this helps? I found this while trying to search around to fix this myself, but my experience is very limited when it comes to mc protocol. https://github.com/TkTech/Burger

DocterDum commented 2 years ago

I tried the fix mentioned above, but joining got the following error (In the proxy terminal and a similar one on the client):

Auth failed: [<twisted.python.failure.Failure OpenSSL.SSL.Error: [('SSL routines', 'tls_process_server_certificate', 'certificate verify failed')]>]

lewisakura commented 2 years ago

Using the NBT dumping example (https://github.com/barneygale/quarry/blob/master/examples/client_data_pack_dumper.py) and a modified version of Quarry to disregard the version difference, I have an NBT file that will now no longer cause the massive disconnect error, but the client will never seem to finish loading terrain. This NBT file was pulled from a fresh, vanilla 1.18.2 server.

I see two major differences with this file, however:

dries007 commented 2 years ago

Release for 1.18.2 created. See release notes on the github release to see how to deal with the "Loading terrain..." issue.