barneygale / quarry

Python library that implements the Minecraft network protocol and data types
Other
532 stars 74 forks source link

Add CI #25

Closed danthedaniel closed 7 years ago

danthedaniel commented 7 years ago

With regard to #13.

You'll need to add barneygale/quarry to Travis CI.

Gjum commented 7 years ago

readme is .rst because it's imported to pypi: https://github.com/barneygale/quarry/blob/master/setup.py#L11

see also https://stackoverflow.com/questions/26737222/pypi-description-markdown-doesnt-work#26737672

danthedaniel commented 7 years ago

Oh, my bad.

On Fri, Feb 17, 2017, 5:07 PM Gjum notifications@github.com wrote:

readme is .rst because it's imported to pypi: https://github.com/barneygale/quarry/blob/master/setup.py#L11

see also https://stackoverflow.com/questions/26737222/pypi-description-markdown-doesnt-work#26737672

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/barneygale/quarry/pull/25#issuecomment-280779911, or mute the thread https://github.com/notifications/unsubscribe-auth/ADISY2xaf0ChM7n1I_abXpmmFqlZ6d_Tks5rdholgaJpZM4MEjXx .

barneygale commented 7 years ago

Amazing stuff! As @Gjum says I think the README needs to stay as a .rst but otherwise thanks a lot for this

barneygale commented 7 years ago

Correct choice of tea by the way, sorry it got cold

danthedaniel commented 7 years ago

I can fix the readme tomorrow if you want.

On Fri, Feb 17, 2017, 10:26 PM Barney Gale notifications@github.com wrote:

Correct choice of tea by the way, sorry it got cold

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/barneygale/quarry/pull/25#issuecomment-280818145, or mute the thread https://github.com/notifications/unsubscribe-auth/ADISY1DU6PGI7u_pe5yOTwqg55Af_lkOks5rdmThgaJpZM4MEjXx .

danthedaniel commented 7 years ago

I finally got around to fixing the readme, all should be good now.

williammck commented 7 years ago

This looks great - thanks for fixing the readme! IMO this can be merged in now, unless @barneygale has any other thoughts.

danthedaniel commented 7 years ago

It turns out that pyopenssl requires a minimum version of 3.3 if you're using Python 3.X, so I changed the supported python versions to "2.7 and 3.3+" in the readme.

barneygale commented 7 years ago

Super, thanks!