barneygale / quarry

Python library that implements the Minecraft network protocol and data types
Other
532 stars 74 forks source link

pack_position 1.14 #72

Closed AlexisHuvier closed 5 years ago

AlexisHuvier commented 5 years ago

Hey, i found a mistake on pack_position function in 1.14 buffer.

You wrote :

return cls.pack('Q', sum((
            pack_twos_comp(26, x) << 38,
            pack_twos_comp(26, z) << 12,
            pack_twos_comp(12, z))))

But one of 'z' must be a 'y'. I think it would be the last.

AlexisHuvier commented 5 years ago

I wiil made a fork and a pull requests