search

barnhill / barcode-java

Java Barcode Image Generation Library
MIT License
25 stars 14 forks source link

The LabelPositions.TOP does not work. #18

Closed EircYangQM closed 1 year ago

EircYangQM commented 2 years ago

The line 914 in barcode.java.

if ((getLabelPosition().ordinal() & Labels.LabelPositions.TOP.ordinal()) > 0)

Labels.LabelPositions.TOP.ordinal() is 0, So it is always 0. Maybe we just check the enum not enum's value.

barnhill commented 2 years ago

Care to create a PR?

EircYangQM commented 2 years ago

I add the PR. please check this.

barnhill commented 1 year ago

This was addressed in https://github.com/barnhill/barcode-java/pull/19. Closing.