Don't pin releases of requirements

[fabaff]

For Home Assistant there is an integration which uses coinmarketcap. In the past we were running into issues if a dependency was pinned to a specific release of one of their requirements.

coinmarketcap is pinning requests==2.18.4 and requests_cache==0.4.13. Could you please consider to ease this?

Thanks

[barnumbirr]

Hello,

I sure could ease the pinned requirements, what would be useful in your case?

Cheers.

[fabaff]

Minimum version would work or if you are planning to maintain it no version at all.

[barnumbirr]

So something like this would work for you:

install_requires=[
    'requests>=2.18.4',
    'requests_cache>=0.4.13'
]

[fabaff]

Yes, because we try to stay up-to-date with our core requirements and requests is one of them.

[barnumbirr]

Ok, I don't think this should have a big impact so I'll happily change this tomorrow.

There's just something I don't understand (if you don't mind clearing that up for me):

Lastest version for requests is 2.18.4, so the same version I have pinned in the setup file and I don't see home-assistant requiring requests-cache as a dependency. Like stated above, don't mind modifing this if it makes your life easier but I just don't seem to grasp where the initial issue is. (Sorry for being daft on this one)

Cheers.

[fabaff]

Ups, sorry, I was talking about requests. At the moment it looks like that requests-cache could be pinned as coinmarketcap is the only module that we use and requires requests-cache. But if it's pinned then we will probably talk again in the future :wink:

[barnumbirr]

v.5.0.3 is now on Pypi and includes fixes in 4e90337bdb467010d310bd796b898acef67d370a.

[fabaff]

Thanks