search

barnumbirr / coinmarketcap

A python wrapper around the https://coinmarketcap.com API.
Apache License 2.0
436 stars 109 forks source link

update ticker documentation to include new params #43

Closed alex-stout closed 6 years ago

alex-stout commented 6 years ago

In the CoinMarketCap documentation for API v2, it "sort" is a parameter that can be included in the query for tickers. I tried it out with the current version of the library and it worked, so I updated the documentation to reflect this.

Also, the current sample return from the ticker call looks like it was sorted via rank and not the default. I updated the example call to reflect this.

barnumbirr commented 6 years ago

Hello,

thanks for the PR. I've just noticed that CoinMarketCap added two new parameters to the //ticker/ query. I'll work on updating the rest of the documentation this weekend and will merge your PR then. (except if you're for documenting the rest of the changes 😏 )

Cheers.

alex-stout commented 6 years ago

I’ll do it for the rest of them either today or tomorrow!

alex-stout commented 6 years ago

Should be all updated now. Just double check to make sure the syntax styling is up to your standards.

barnumbirr commented 6 years ago

LGTM. Thanks for the PR. 😄