Feature Request: Set individual logging intervals per URL

baronbrew / TILTpi

Baron Brew Equipment Official Tilt app for Raspberry Pi

62 stars 18 forks source link

Feature Request: Set individual logging intervals per URL #24

Open Romfrosk opened 4 years ago

Romfrosk commented 4 years ago

Hi.

I'd love to be able to log at different intervals to URLs.

BrewSpy can handle every 5m Brewfather can handle every 15m Google can probably handle every minute if not more often.

noahbaron commented 4 years ago

Hi, I agree, that would be a great feature. We will definitely add it to our roadmap. I assume that setting the interval to 5 min will cause a problem if trying to use Brewfather?

On Mon, Jun 15, 2020 at 10:47 AM Romfrosk notifications@github.com wrote:

Hi.

I'd love to be able to log at different intervals to URLs.

BrewSpy can handle every 5m Brewfather can handle every 15m Google can probably handle every minute if not more often.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/baronbrew/TILTpi/issues/24, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQ3FBNHHGR5OUGNWZNJO6DRWZNDDANCNFSM4N6MU3LA .

Romfrosk commented 4 years ago

Yes. They do mention that 15m is the lowest value.

I will test to set it at 5 minutes and see if it just skips the values coming in too quick, or if it also blocks those coming in every 15m.

Can't test until my beer has been bottled though.

tmack8001 commented 3 years ago

I believe from when I was looking at reworking the custom urls in nodered that yes BrewFather does ignore anything that comes in sooner than the 15m window, not sure of the specifics off the top of my head.

Overall this is a much welcomed addition. I'll look to see if I can resurrect my flow that had something similar to this, but missing edge case testing.

tmack8001 commented 3 years ago

This is what the UI looked like on my branch (not complete). It would store properties in a map data structure for each of the "cloud logging providers" created (frequency, url, enabled and name) I think were all specific to the provider being updated.

tmack8001 commented 3 years ago

For instance here I have brewfather (not named) and google sheets (though have the same time interval set for both right now).

When I built this I also thought we should make it so the user can't "delete" the google sheets entry, but rather just disable it thus the "enabled" toggle and an uneditable Default Google Sheets entry.

Not sure when I'll have time to come back to this and learn more about NodeRED to make sure I catch all the edge cases that might happen, but who knows might try to finish this off.