search

baronbrew / TILTpi

Baron Brew Equipment Official Tilt app for Raspberry Pi
62 stars 18 forks source link

Logging does not record temperature in set unit #5

Open greyghostbrewery opened 5 years ago

greyghostbrewery commented 5 years ago

The log files only include the temperature in Fahrenheit even when the display unit has been changed to Celsius.

billsegall commented 5 years ago

I had thought this was also an issue in TiltPi's main screen but in fact it's just a UI issue which the attached image shows

greyscale

In this image Celsius is a lighter shade of gray and hence to me looks like it is on. It is in fact fahrenheit that is selected.

Could I recommend red and green as color choice for options rather than two shades of gray. Or perhaps instead of two linked sliders a dropdown option for this choice (but that might not assist the other boolean options).

noahbaron commented 5 years ago

I agree, it's an odd representation. It's the default coloring using the node-red UI node plugin. Something to investigate on the next version.

Regarding the display units vs. logged units. The assumption was that any CSV file would be used with a pre-formatted template in Excel so any unit conversions would be done there. It also prevents the numbers from going haywire should the units be changed mid-way through a brew. One work around would be to have a master log file with the native units and upon download convert the units based on the current selection.

billsegall commented 5 years ago

As a representative of a country using the metric system (the exceptions being Myanmar, Liberia and the USA) I would obviously like to see Celsius being the default :-)

You might choose kelvin as an independent option but ultimately it's kinda futile when the tiltpi itself is designed for the US market and reports in farenheit and has a granularity in farenheit (.5 deg).

Another option would be to use the locale to make this choice in the log, or as you suggest to allow the logging units to be set.

My issue was more in the UI and I'm happy with it now that I know how to make it appear in my units of choice. My apologies for hijacking this issue with that.