search

barosl / homu

A bot that integrates with GitHub and your favorite continuous integration service
http://homu.io/
MIT License
661 stars 102 forks source link

Support GitLab #119

Open emberian opened 8 years ago

emberian commented 8 years ago

GitLab is a free software alternative to GitHub. It would be nice if homu supported it out-of-the-box.

sigmavirus24 commented 8 years ago

I'll go ahead and disagree rather strongly at the moment.

homu is a tiny tool that works very well. It works well because it's feature-set is currently very small, its architecture is simple, and its well written and maintained. While introducing support for GitLab would probably introduce some great refactoring opportunities (e.g., separating parsing of comments and interaction with a service) I think the project doesn't need to introduce a large scale refactoring at the moment (as much as I want more services to support both GitHub and GitLab).

A fork of homu should be made to support GitLab. Ideally, it would not introduce new features that homu hasn't introduced, but it would support GitLab instead of GitHub. If that proves popular enough, merging the two projects could then be done slowly through a series of pull requests that refactor pieces away from the platform it is supporting.

Does that make sense?

barosl commented 8 years ago

Actually I've thought from the beginning that Homu should probably support at least BitBucket. I admire GitHub, but at the same time I feel a vague sense that I should not contribute to the so-called GitHub monoculture. Unfortunately Homu didn't get much attention on supporting other source repositories. One of the obstacles was that the BitBucket API lacks direct Git manipulation that Homu requires, but thankfully Homu recently gained a feature to directly use the local Git command. I don't think adding support for BitBucket and GitLab is that much hassle. So I think it should be done someday.

MOZGIII commented 8 years ago

Any news here? :newspaper:

zitsen commented 8 years ago

Any news here?