search

barosl / homu

A bot that integrates with GitHub and your favorite continuous integration service
http://homu.io/
MIT License
661 stars 108 forks source link

Add more maintainers :-) #122

Open larsbergstrom opened 8 years ago

larsbergstrom commented 8 years ago

@barosl, would you be open to adding some more reviewers to homu? There are many of us who'd love to continue supporting, extending, and adding features while you are busy with other things, and we'd prefer not to do that work in a separate fork!

Feel free to DM me on irc.mozilla.org to chat (larsberg) if you'd like to chat about it more :-)

edunham commented 8 years ago

Just a quick update, we discussed this at the last Servo meeting and we're going to temporarily continue development in the Servo fork in order to merge changes we need for our production Homu instance. @barosl, we really appreciate your work on Homu, and we hope to reunite the forks once you get back.

barosl commented 8 years ago

Sorry for the HUGE delay. There were some big personal obstacles in my life recently, and because of that I've been distracted from the open source projects for months. Now that the problem is resolved, I think I can go on. If I were to add more maintainers @Manishearth will be one of them.

I actually think testing new features on the Servo fork might be a good idea to test new features rapidly. I'm very poor at making decisions, and maybe I take pull requests too seriously. So I try to check if the pull requests are in perfect state again and again, before actually merging them. I think this attitude is not very useful, and even think it's quite wasteful, but I cannot resist such urges.

One of the consequences of this is that it can take so much time for me to accept some pull requests, especially large ones. That's why I think testing them directly on the Servo fork may be beneficial. However, it is also true that maintaining two repositories costs is a bit more work. I'm again poor at decisions!

larsbergstrom commented 8 years ago

@barosl Welcome back! Please don't hesitate to reach out to us (or me personally - larsberg @ mozilla.com) if there's anything we can do to help.

I think we're happy to maintain a fork and help with landing them back in your main upstream repository, if you'd prefer that workstyle.

Also, @Manishearth mentioned you have some private test scripts that you run on homu before landing a PR. We could also help with automating those tests via Travis, if that would help make it easier to land things without fear that stuff will break!

Again, glad to see you back and hope that all is better for you!

Manishearth commented 8 years ago

Yeah, I'm okay with keeping a fork both so that we can field test features (which get upstreamed later) and also so that we can make Servo-specific changes.

Welcome back!

cgwalters commented 8 years ago

FWIW I could spend (and just have spent) some time helping with review. I'm investigating using Homu for a work project and I could justify a small amount of time on maintenance. I'm not sure I agree with the Servo fork approach. How about instead, create a git branch called stable or whatever, then we iterate a lot in master? It's git, one can always go back.

cgwalters commented 8 years ago

Should we move our PRs to the Servo fork?

Manishearth commented 8 years ago

Fine by me.

nightpool commented 8 years ago

Hey, I'm part of an open-source project that uses homu.io as part of our build infrastructure. It seems like over the past few weeks the hosted version has stopped working. Is there a plan to bring it back going forward?

tagging @erickt who expressed interest in homu.io

Manishearth commented 8 years ago

The rust community team is considering hosting their own instance for use by everyone, yes 😄