Only generate completion on target host improves build times

barracuda-cloudgen-access / access-cli

Allows to access all CloudGen Access Enterprise Console APIs from the command line.

Apache License 2.0

10 stars 4 forks source link

Only generate completion on target host improves build times #28

Closed oNaiPs closed 3 years ago

elyscape commented 3 years ago

This seems to me like it would require the linux_amd64 build to run first in order for the completion scripts to be properly bundled on other platforms.

oNaiPs commented 3 years ago

@elyscape the hook is producing the result on the same target folder, and archiving is only done after the build stage is finished.

Main reason for this proposal was that (if I'm getting this right) you need to build the CLI in the pre stage.

Not 100% happy with the outcome though since goreleaser could change the way the build stages are handled

oNaiPs commented 3 years ago

Closing this issue since we could inadvertly introduce packaging problems in the future. Will re-visit if I find a more elegant solution