search

barraq / deck.ext.js

Provide extensions, themes and use cases for deck.js
17 stars 7 forks source link

Fix example for notes documentation #5

Closed maxbeizer closed 7 years ago

maxbeizer commented 10 years ago

I was attempting to implement the clone and notes extensions and it was not working for me. I noticed on line 32 of extensions/notes/deck.notes.js that the selector should be .deck-notes instead of what the documentation says: .notes . This PR just updates the README for the next user.

Thank you very much for these extensions! :+1:

barraq commented 10 years ago

Hi @maxbeizer , thanks for pointing that out ;) nevertheless I guess there is also another small bug on line 95 https://github.com/barraq/deck.ext.js/blob/master/extensions/notes/deck.notes.js#L95 where I use ".notes" instead of classes.notes. Could you fix it as well and add it to your patch before I apply it?

Thanks

maxbeizer commented 10 years ago

@barraq sorry about commit 4db44e7. I misread your request. I hope e930a74 sufficiently fixes the issue. Merci.

eric-wieser commented 7 years ago

The documentation is correct, but is missing the instructions to add a container to place the notes in:

<div class="deck-notes">
        <div class="deck-notes-header">Notes</div>
        <div class="deck-notes-container"></div>
</div>
maxbeizer commented 7 years ago

Since this PR is over three years old and I can't remember what I was trying to fix, I'm going to go ahead and close it.