search

barreiroleo / ltex_extra.nvim

Provides external LTeX file handling (off-spec lsp) and other functions.
GNU General Public License v3.0
142 stars 15 forks source link

feat(config): ltex_extra sets lspconfig for users #29

Closed fhfuih closed 1 year ago

fhfuih commented 1 year ago

The new setup method is documented in the README file. Also, this PR removes default load_langs (en and es) which may not get rid of when merging options. This PR also replaces deprecated lsp API.

barreiroleo commented 1 year ago

Hi @fhfuih! Nice to see another PR of yours. I really appreciate the changes, I wanted to change the setup way (and add the stylua, haha). The code looks good to me but as I said in the issue, I'll try to test it at the weekend. Thank you!

fhfuih commented 1 year ago

Sure! I am writing a lit survey in LaTeX recently, so I have been constantly tweaking my latex configuration in neovim.

And pleeaaase do test. I also did some quick tests, but that requires me to switching my configs back and forth to fit in the two paradigms so I'm not sure whether my test is dirty or clean. Please also check the README file, in case some lines isn't clear enough.

And yes, I noticed you don't have stylua for now, but styling is quite personal, so I leave it up to you haha.

barreiroleo commented 1 year ago

I am back on this, very sorry for the delay, busy time.

I want to make the server setup optional to not break the configs of the users and let them decide how to initialize. There are people with very customized on_attach processes and force to initialize ltex from ltex_extra might cause conflict. So, I'll merge this PR in a separate branch and work on it. Probably it will be a simple check of the server_opts and call lspconfig if exist.

Very thank you one more time

fhfuih commented 1 year ago

No problem, that’s what open source means :) Also thanks for the continuous work on this PR. Also, I am considering moving away from (n)vim because indeed I realize I am one of many guys who simply rebuild another VSCode… I want to save time for other hobbies and my schoolwork. So perhaps I won’t use this plugin any longer. But anyway, if there is anything specifically related to this PR, I am glad to help! 在 2023年4月15日 +0800 01:38，Leonardo A. Barreiro @.***>，写道：

I am back on this, very sorry for the delay, busy time. I want to make the server setup optional to not break the configs of the users and let them decide how to initialize. There are people with very customized on_attach processes and force to initialize ltex from ltex_extra might cause conflict. So, I'll merge this PR in a separate branch and work on it. Probably it will be a simple check of the server_opts and call lspconfig if exist. Very thank you one more time — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>