search

barrel-db / rebar3_elixir_compile

Elixir rebar3 compiler plugin
Other
90 stars 29 forks source link

Read MIX_ENV variable #32

Closed kubaodias closed 6 years ago

benoitc commented 6 years ago

shouldn't it be merged with the env instead?

kubaodias commented 6 years ago

If I understand this correctly env is just a single value e.g.

{elixir_opts, 
  [
    {env, dev}
  ]
}.

So if MIX_ENV is present it has precedence before env tuple from config.

tsloughter commented 6 years ago

Right, mix only supports dev and prod and does not combine them like rebar3 does with profiles.

benoitc commented 6 years ago

merged , thanks

kubaodias commented 6 years ago

Thanks! Do you plan to make a release to hex.pm ?

benoitc commented 6 years ago

yes. i will try later today

On Tuesday, July 3, 2018, Kuba Odias notifications@github.com wrote:

Thanks! Do you plan to make a release to hex.pm ?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/barrel-db/rebar3_elixir_compile/pull/32#issuecomment-402014966, or mute the thread https://github.com/notifications/unsubscribe-auth/AAA4oh62VXcnpVa8pANIRY1XiLaFfwTdks5uCvzxgaJpZM4UNl9F .

-- Sent from my Mobile